Dima353/openal-soft
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid ugly reinterpret_casts with offsetof

Browse Source
This commit is contained in:
Chris Robinson
2020-12-29 09:57:08 -08:00
parent 96942d7968
commit ec7e7c9174
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
al/auxeffectslot.cpp
+12 -6
View File
@@ -991,13 +991,19 @@ void ALeffectslot::updateProps(ALCcontext *context)
void UpdateAllEffectSlotProps(ALCcontext *context) void UpdateAllEffectSlotProps(ALCcontext *context)
{ {
std::lock_guard<std::mutex> _{context->mEffectSlotLock}; std::lock_guard<std::mutex> _{context->mEffectSlotLock};
EffectSlotArray *slots{context->mActiveAuxSlots.load(std::memory_order_acquire)}; for(auto &sublist : context->mEffectSlotList)
for(EffectSlot *slot : *slots)
{ {
ALeffectslot *auxslot{reinterpret_cast<ALeffectslot*>( uint64_t usemask{~sublist.FreeMask};
reinterpret_cast<al::byte*>(slot) - offsetof(ALeffectslot,mSlot))}; while(usemask)
if(!auxslot->PropsClean.test_and_set(std::memory_order_acq_rel)) {
auxslot->updateProps(context); const int idx{CountTrailingZeros(usemask)};
ALeffectslot *slot{sublist.EffectSlots + idx};
usemask &= ~(1_u64 << idx);
if(slot->mState != SlotState::Stopped
&& slot->PropsClean.test_and_set(std::memory_order_acq_rel))
slot->updateProps(context);
}
} }
} }